-
Notifications
You must be signed in to change notification settings - Fork 120
Sylvainsf/remove approval workflow #11077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
|
There seems to be some permission issues. |
DariuszPorowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
brooke-hamilton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR removes the manual approval workflow for functional tests and simplifies the CI architecture by using GitHub's native fork approval mechanism.
Changes Made
Removed Files
.github/workflows/functional-tests-approval.yaml- The manual approval workflow that gated functional tests.github/actions/download-pr-data-artifact/- The composite action that retrieved PR numbers from approval workflow artifactsModified Files
.github/workflows/functional-test-cloud.yaml:workflow_runtrigger (dependent on "Approve Functional Tests") with directpull_requesttriggerworkflow_run-specific environment variables and loggingifconditions to usepull_requestinstead ofworkflow_runBenefits
pull_requesttrigger instead ofworkflow_runchainConfiguration Required
GitHub organization/repository settings have been configured:
This ensures org members' PRs run automatically while external contributors' PRs wait for maintainer approval using GitHub's native UI.
Type of change
Fixes: N/A
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: